Fix: Standardize CI change-detection filters and fix power_ups path typo#702
Merged
TalShafir1 merged 2 commits intochronicle:mainfrom Apr 21, 2026
Merged
Conversation
The path filters in 5 workflow files referenced `power_up/` instead of `power_ups/`, causing validate, build, lint, code check, and Windows CI jobs to silently skip when power_ups integrations were modified. This allowed PR chronicle#686 to pass CI without version bump or release notes validation.
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
TalShafir1
approved these changes
Apr 21, 2026
eranc-google
changed the title
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug fix: Path filters in 5 workflow files referenced
power_up/instead of the correctpower_ups/directory, causing validate/build/lint/code-check/Windows CI jobs to silently skip forpower_ups/integrations (e.g.,git_syncin PR #686).Standardization: Split the
mpdorny/paths-filter intomp(packages/mp/**) andci(.github/workflows/**) so workflow-only changes no longer trigger full integration validate/build/test runs (~15 min on Windows, ~5 min on Linux). Also standardized filter definitions across all workflows.Skip labels: Added PR label-based skipping for expensive CI jobs.
Changes
validate.ymlpower_upstypo. Remove.github/workflows/**from paths + mp filter. Fix stale comment.build.ymlpower_upstypo. Remove.github/workflows/**from paths + mp filter. Addskip-build+ci-minimallabel support.lint.ymlpower_upstypo. Remove.github/workflows/**from paths. Consolidate package filters intointegration_packages. Addmpto lint job conditions.third_party_code_check.ymlpower_upstypo (2 occurrences).windows_workflows.ymlpower_upstypo. Add top-levelpaths:filter. Splitmp/cifilters. Add missingintegration_testing_whls. Addskip-windows+ci-minimallabel support (keepstest-mp-windowsrunning).test.yml.github/workflows/**from paths + mp filter. Addskip-tests+ci-minimallabel support.test_mp.yml.github/workflows/**to paths so mp tests run on CI changes..gitignore.claude/directory.CI skip labels
After merge, create these labels in the repo:
ci-minimalskip-windowstest-mp-windows)skip-teststest.yml)skip-buildbuild.yml)Trigger behavior after this change
packages/mp/**.github/workflows/**packages/{envcommon,tipcommon,...}/**content/.../google/**content/.../third_party/**orpower_ups/**content/playbooks/**Checklist
Test plan
CodeQLis a required status check - none of the modified job names are required.github/workflows/**+.gitignore- onlytest_mp.ymlandwindows_workflows.ymltest-mp-windowsshould trigger real workgithub.event_name != 'pull_request') where needed